fix: allow multistage Dockerfiles by removing AS <stage name> in validation#112
Merged
arnaugiralt merged 4 commits intomasterfrom Feb 28, 2026
Merged
fix: allow multistage Dockerfiles by removing AS <stage name> in validation#112arnaugiralt merged 4 commits intomasterfrom
arnaugiralt merged 4 commits intomasterfrom
Conversation
Sainomori
force-pushed
the
issue-103-allow-multistage
branch
2 times, most recently
from
f94e9a0 to
73cff33
Compare
|
…dation - Modified the validate_docker_compose_yml function to support multistage Dockerfiles. - Updated the FROM line parsing to remove the AS <stage name> part for case-insensitive comparison. - This ensures compatibility with Dockerfiles using multistage builds.
Prevent file handle leak by wrapping the Dockerfile open() call in a with statement. Update test mocks to support context manager protocol.
arnaugiralt
force-pushed
the
issue-103-allow-multistage
branch
from
73cff33 to
0887be3
Compare
Member
|
This PR is still useful, so I rebased it against master and fixed a couple of things:
|
jonatrios
previously approved these changes
Feb 27, 2026
qarlosh
requested changes
Feb 27, 2026
Docker image names are case-insensitive, so the base image check in Dockerfile validation should not fail on casing differences. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
qarlosh
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #103